feat: support ClusterTrustBundle in CACertificateRefs #6353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (53.99%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #6353 +/- ##
==========================================
+ Coverage 70.78% 71.06% +0.28%
==========================================
Files 224 225 +1
Lines 38648 38883 +235
==========================================
+ Hits 27357 27634 +277
+ Misses 9701 9653 -48
- Partials 1590 1596 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
wait #6352 |
zirain
force-pushed
the
clustertrustbundles
branch
2 times, most recently
from
e1f796f to
233430d
Compare
zirain
force-pushed
the
clustertrustbundles
branch
from
233430d to
d9e8483
Compare
zirain
force-pushed
the
clustertrustbundles
branch
3 times, most recently
from
6ca957c to
94f7ad6
Compare
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
zirain
force-pushed
the
clustertrustbundles
branch
from
b74196d to
f50407f
Compare
zirain
force-pushed
the
clustertrustbundles
branch
from
0f516ed to
0d4a55a
Compare
zirain
force-pushed
the
clustertrustbundles
branch
from
0d4a55a to
a8fcbfa
Compare
zhaohuabing
reviewed
Jul 7, 2025
zhaohuabing
reviewed
Jul 7, 2025
internal/gatewayapi/testdata/backendtlspolicy-ca-clustertrustbundle.in.yaml
Outdated
Show resolved
Hide resolved
zirain
commented
Jul 7, 2025
Comment on lines
+34
to
+36
| message: |- | ||
| TLS: caCertificateRef secret [tls-secret-1] not found | ||
| TLS: caCertificateRef secret [tls-secret-1] not found. |
There was a problem hiding this comment.
shouldn't happen twice, better to fix this later.
There was a problem hiding this comment.
Is this related to how many listeners in the referenced Gateway?
zirain
force-pushed
the
clustertrustbundles
branch
from
413a440 to
35e58fb
Compare
zirain
force-pushed
the
clustertrustbundles
branch
from
d35fcfd to
daee39f
Compare
arkodg
reviewed
Jul 22, 2025
|
thanks @zirain, one minor comment, else LGTM |
arkodg
previously approved these changes
Jul 23, 2025
arkodg
previously approved these changes
Jul 23, 2025
zhaohuabing
previously approved these changes
Jul 23, 2025
Signed-off-by: Arko Dasgupta <arkodg@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref: #6351